Reference to constant that does not exist

Created on 1 November 2023, over 1 year ago

Problem/Motivation

In OrangeDamConfigurationManager.php there is a use statement for a class that does not exist.

use Drupal\jfkl_orange_dam\OrangeDamContentManager;

This class provides a constant used later in the code.

OrangeDamContentManager::LOGGER_CHANNEL

Since this jfkl_orange_dam\OrangeDamContentManager class cannot be expected to exist anywhere (it is not included in composer.json), this will lead to a fatal error.

Proposed resolution

Provide a class constant for a logger channel that is native to this class.

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States apotek

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @apotek
@apotek opened merge request.
Status changed to RTBC over 1 year ago2:22pm 1 November 2023
Comment over 1 year ago →
🇺🇸United States markdorison
You beat me to it! I came here to report his issue. The diff LGTM.

I am going to create a separate issue/MR to get PHPStan configured in composer.json so this is easier to run/catch locally.
Status changed to Fixed over 1 year ago3:57pm 1 November 2023
Comment over 1 year ago →
🇺🇸United States apotek
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024