- Issue created by @pbonnefoi
- Merge request !32issue #3398071: init .gitlab-ci.yml file to the module β (Merged) created by pbonnefoi
- last update
about 1 year ago 83 pass - Status changed to Needs work
about 1 year ago 12:34am 8 November 2023 - πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
This is linting e.g. the build js, which adds tons of noise and makes this impractical.
I'm pretty sure there's some way we can configure that to be ignored before enabling gitlabci. - π«π·France pbonnefoi
Well, in my opinion, since the module is using js and css, eslint must be enabled. Adding gitlab-ci to modules is the new norm. Helps improve the code quality and best practices overall. We will open other tickets to fix code issues.
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
I'm not asking to skip eslint, I'm asking to ignore compiled files.
Core is using .eslintignore https://git.drupalcode.org/project/drupal/-/blob/11.x/core/.eslintignore...
We should do that and ignore js/build/* - First commit to issue fork.
- last update
about 1 year ago 83 pass - Status changed to Needs review
about 1 year ago 7:54pm 13 December 2023 - πΊπΈUnited States mark_fullmer Tucson
The suggestion of adding the .eslintignore file makes sense to me. Added in the most recent commit to the merge request.
- last update
10 months ago 83 pass -
mark_fullmer β
committed 4c980f6f on 6.1.x authored by
pbonnefoi β
Issue #3398071: Add .gitlab-ci.yml to Linkit
-
mark_fullmer β
committed 4c980f6f on 6.1.x authored by
pbonnefoi β
- Status changed to Fixed
10 months ago 8:59pm 24 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.