Contrib.social

Should we Invalidate the page cache after saving settings?

Open on Drupal.org →
Created on 30 October 2023, 8 months ago

Problem/Motivation

When testing the admin form, I noticed that if an anonymous user has a session, and requested a pattern and got a response, then the same pattern is saved in the form, then the same user requested that pattern, they get served a response from the page cache.

Steps to reproduce

Check the steps in the testUrlBanning() test. If you remove clearing the cache from that test, It becomes a test for this issue.

Proposed resolution

Discuss whether this edge case requires clearing the page cache when saving the form.

Remaining tasks

Discussion
Action plan

User interface changes

None

API changes

None

Data model changes

None

🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇸🇪Sweden alayham

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @alayham
  • Comment 8 months ago →
    🇸🇪Sweden alayham

    I think the overhead of clearing the cache is not worth it. We will be punishing the real users and the server/database for a very rare edge case.

    If we are doing this, then at least we should add a checkbox to make purging the page cache optional.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024