- Issue created by @guiu.rocafort.ferrer
- last update
about 1 year ago 55 pass - last update
about 1 year ago 55 pass - last update
about 1 year ago 55 pass - last update
about 1 year ago 55 pass - last update
about 1 year ago 55 pass - last update
about 1 year ago 55 pass - 🇪🇸Spain guiu.rocafort.ferrer Barcelona
Looks like the eslint job is failing because the current .eslint.json file present in the module code depends on the eslint-config-drupal npm package ( https://www.npmjs.com/package/eslint-config-drupal ). This package does not come in core package.json which is installed during the composer previous job, and it's artifacts are imported into the eslint job.
I am thinking a good approach would be just to make a .eslint.json which would reference the core existing .eslint.json file. This way we don't have to worry about updating the eslint configuration if it changes in core.
- last update
about 1 year ago 55 pass - last update
about 1 year ago 55 pass - last update
about 1 year ago 55 pass - last update
about 1 year ago 55 pass - last update
about 1 year ago 53 pass, 2 fail - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22last update
11 months ago Not currently mergeable. - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22last update
11 months ago Not currently mergeable. - 🇪🇸Spain guiu.rocafort.ferrer Barcelona
For some reason de phpunit functional tests started to fail with the error "Test was run in child process and ended unexpectedly".
I think that if we manage to fix this problem, we could merge the gitlab CI pipelines and fix the phpstan and eslint warnings in a different issue. - Status changed to Fixed
10 months ago 8:53pm 13 January 2024 - 🇺🇸United States justin2pin
Thanks @guiu.rocafort.ferrer - I missed that this had been added as an issue and just now added the Gitlab CI config. Tests appear to be running as expected, although they are failing for 10.2 (I'll add a separate issue for that).
Yes, let's add separate issues for phpstan, phpcs, eslint, etc.
Thanks again.
Automatically closed - issue fixed for 2 weeks with no activity.