Contrib.social

XML Namespace incorrect in placeholder SVG

Open on Drupal.org →
Created on 30 October 2023, 8 months ago
Updated 4 November 2023, 8 months ago

Problem/Motivation

A previous commi to the codebase - 221e0d03 - made a change to src/Media/Placeholder.php that breaks the encoded SVG by altering the XMLNS value. The switch from "http" to "https" here is incorrect and makes the namespace invalid.

This is causing the img placeholder to render as a broken image icon.

See the correct namespace spec from w3.org.

Steps to reproduce

Use the service with an SVG placeholder.

Proposed resolution

Remove the "s" in lines 22, 24, and 104 in src/Media/Placeholder.php

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

2.21

Component

Code

Created by

🇺🇸United States R_H-L

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024