- Issue created by @mfb
- Status changed to Needs work
about 1 year ago 3:23pm 30 October 2023 - πΊπΈUnited States Chris Burge
I agree that fragments are valid in scheme URLs. The patch workflow is incompatible with GitLab CI, so we'll need an MR to proceed. Let's also add test coverage (Drupal\Tests\oembed_providers\Unit\UrlIsValidTest) for 1) disallowing user and pass elements and 2) allowing fragments.
- @mfb opened merge request.
- Status changed to Needs review
about 1 year ago 4:49pm 30 October 2023 -
Chris Burge β
committed 3d2e9966 on 2.x authored by
mfb β
Issue #3397563 by mfb, Chris Burge: Fragments are valid in oEmbed scheme...
-
Chris Burge β
committed 3d2e9966 on 2.x authored by
mfb β
- Status changed to Fixed
about 1 year ago 4:05pm 31 October 2023 - πΊπΈUnited States mfb San Francisco
Great, thanks! By the way, to actually make use of this, I also found this issue over in drupal core: π OEmbed generates URLs with URL-decoded query string Needs review
Automatically closed - issue fixed for 2 weeks with no activity.