- Issue created by @lammensj
- Status changed to Needs review
about 1 year ago 11:18am 30 October 2023 - 🇧🇪Belgium lammensj
I've created the mentioned plugin manager and added plugins for the existing locations that are already part of the Guzzle-package. Let me know what you think :)
- 🇮🇹Italy aronne
Hi @lammensj,
I took a look at your work and I really love what you've done.
I would avoid putting this implementation into a separate module, I prefer the 2nd option.
Tho we must be 100% sure this new implementation doesn't break already existing service descriptions so if you could add some tests it would be great! - 🇧🇪Belgium lammensj
@aronne, glad you approve!
I've added some unit-tests for the specific plugins that are included, based on the same unit tests as for the guzzle-service package itself: see https://github.com/guzzle/guzzle-services/tree/1.4.0/tests/RequestLocation. I've also updated the HttpClient-test by prophezing the plugin manager and injecting it. Is this sufficient? - 🇮🇹Italy aronne
Hi @lammensj,
great job again, thank you.
Could you please open a MR or upload a patch so that we can go online with your feature?Regards,
aronne - @lammensj opened merge request.
- 🇧🇪Belgium lammensj
PR for the general functionality is created.
What's your take on the additional RequestLocation-plugin for body-payloads without a key? Do you think it should be/can be included in this module or something a developer now might create itself? - 🇮🇹Italy aronne
Hi @lammensj,
I think you could add it directly in this module. - 🇧🇪Belgium lammensj
@aronne, I've added the extra plugin and a test to the PR.
-
lammensj →
authored 28c2e80a on 3.x
Issue #3397521 by lammensj: Locations as plugin
-
lammensj →
authored 28c2e80a on 3.x
- Status changed to Fixed
about 1 year ago 6:45am 3 November 2023 - 🇮🇹Italy aronne
Hi @lammensj,
thank you for the great job you've done with this implementation.
I'm gonna create a new release soon.Kind regards,
aronne -
lammensj →
authored c73d8903 on 9.3.x
Issue #3397521 by lammensj: Locations as plugin
-
lammensj →
authored c73d8903 on 9.3.x
Automatically closed - issue fixed for 2 weeks with no activity.