[beta5] Single checkbox/radio error class/message

Hi,

I've looked into the issue regarding the single checkbox/radio error class/message and have identified the root cause.
I've attached a patch that implements this fix. Here's what I've changed:

1- Replaced the condition checking for #delta with #error_no_message to determine if an error should be added.
2- Adjusted the logic for setting the $error_class variable based on this new condition.

Please test the patch. Looking forward to feedback!

thanks, I will have a look

Looks great. Can you do a git MR instead of a patch?

Certainly!

I've created a Merge Request (MR) with the changes.

Let me know if there's anything else needed. Thank you!

I see your commit: https://git.drupalcode.org/issue/ui_suite_dsfr-3396957/-/commit/b654066b...

It is a great and I want to merge it, but I don't find the MR (and I don't know how to create it myself. I guess you have to create it).

Thank you for your feedback!

My apologies for the oversight. I've now created the MR. You can review and merge it. Appreciate your patience!

Merged, thanks

Hello,

Thanks to both of you for the quick actions !

However I'm afraid there is a typo in the fix, on line 217 : the condition should be on $variables['add_error'] instead of !$variables['add_error'] (= the error class should be added only if "add_error" is true).

Thanks a lot.

Tom'as can you have a look? I guess it is possible to add a commit in the MR.

Hi @pdureau and @mh_nichts,

Thank you for the catch! I've reviewed the code and you're correct about the error class condition.

I've made the necessary update and pushed the commit.
I've observed that my latest commit addressing the error class condition is present in the repository on the original branch, which confirms the push was successful. However, this update isn't reflected on the changes page linked from the issue.

Could anyone clarify if I should create a new merge request for this fix, or if there is another step I should take?

Appreciate your help on the next steps.

Hello,

Could anyone clarify if I should create a new merge request for this fix, or if there is another step I should take?

I am more familiar with the "vanilla" gitlab workflow than the Drupal one, so I was bealieving you can add a new commit in your already merged but still available MR: https://git.drupalcode.org/project/ui_suite_dsfr/-/merge_requests/40

Anyway, if you can"t do that, no need for a new issue. You can create a new fork or a new branch in the actual issue.

Hi @pdureau,

Following up on the recent discussion, I've created a new branch 3396957-Single-checkbox-radio-error with the updated fix where I've removed the ! operator as suggested. I've pushed this branch and created a new merge request to address the typo mentioned earlier.

Here's the link to the new merge request for review.

I look forward to any reviews or comments.

Merged. Credit given to both tguerineau & mh_nichts.

Automatically closed - issue fixed for 2 weeks with no activity.