Make timestamp required

Let's see if this breaks any tests...

This LGTM. Trying to think where else this change could cause issues but not sure. Glad this doesn't break JSON:API!

I'm going to merge this and tag 2.2.0. It probably doesn't need a minor release, but I felt that was a bit safer than a patch release, just in case we find that this causes any issues.

Automatically closed - issue fixed for 2 weeks with no activity.

Unfortunately this has caused a breaking change starting with Drupal 10.2. The log entity form no longer sets the default value for the timestamp field and because the field is required, a value must be entered in order to submit the form. If the field was optional then I believe

Previously the datetime_timestamp widget would always use default value set for the field at $items[$delta]->value but now this widget only uses the default value if the parent entity (the log) is not new. This was changed in 🐛 Remove sample date from date field error message and title attribute Fixed : https://git.drupalcode.org/project/drupal/-/commit/5404ebfb11155b53dee0e...

Just re-opening this issue to flag this... we may want to open a new issue in Log or contribute to Drupal core to fix. I left a comment in the relevant issue for now: https://www.drupal.org/project/drupal/issues/2791693#comment-15399165 🐛 Remove sample date from date field error message and title attribute Fixed

I've opened a new issue in Drupal core: 🐛 Datetime_timestamp widget does not use default field value Active

Thanks @paul121! Reading your comments in 🐛 Remove sample date from date field error message and title attribute Fixed and 🐛 Datetime_timestamp widget does not use default field value Active , it does indeed sound like a core issue, not a Log module issue (although we were the lucky ones to discover it with this change). I think we can leave this closed, patch core in farmOS (until they merge your fix), and refer other Log users there if anyone experiences it. Thanks for identifying this and for making that quick core patch!

Automatically closed - issue fixed for 2 weeks with no activity.