ConfigInspectorItemForm::buildFormConfigElement() should use a type hierarchy instead of hardcoding form items for types

Created on 24 October 2023, about 1 year ago

Updated 9 January 2024, 10 months ago

Problem/Motivation

Discovered while making tests run on Drupal 10.2 over at 📌 Adopt GitLab CI Fixed .

Drupal 10.2 added:

Consequently, the hardcoded logic in \Drupal\config_inspector\Form\ConfigInspectorItemForm::buildFormConfigElement() that only supports a dozen or so types no longer works. And it has never worked for contrib-defined types.

Steps to reproduce

Use Config Inspector 2.1.5 on Drupal 10.2.x.

Proposed resolution

Use a type hierarchy to determine appropriate form elements: required_label extends label which extends string.
Bonus points: when installed, use Content Translation's config_translation_config_schema_info_alter() hardcoded improvements.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Needs work

Version

2.1

Component

Code

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @wim leers
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update about 1 year ago
3 pass
@wim-leers opened merge request.
Status changed to Needs work about 1 year ago11:31am 24 October 2023
Comment about 1 year ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
A hard-coded work-around is available in the MR, but this really should implement the proposed resolution instead.
Comment 10 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I was forced to introduce a subset of this in 📌 Make tests pass on Drupal 10.2 Fixed , for type: required_label.

It's still not using the full type hierarchy though; it's just using class (BooleanData, StringData, etc.).

So this issue remains relevant, but is less urgent now.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024