- Issue created by @spuky
- Assigned to Mohd Sahzad
Please ask your managers to make some donations to support the development of the module.
- Issue was unassigned.
- 🇮🇳India Mohd Sahzad
I have updated this issue in attached patched patche1 please review.
- Status changed to Needs review
8 months ago 8:00am 23 October 2023 - 🇩🇪Germany spuky
@Mohd Sahzad here is my review of your Patch
your patch is missing the JS Code to to use drupal/once instead of jquery.once
see my patch that came wit the Feature request..also you are stating that the module works with D8 but list drupal/once as a library which does not exits for D8
also D8 is EOL since November 2021 so nobody needs encouragement to stay on 8Looking forward for the review of mine ;-)
@wombatbuddy my patch is already working... and tested
on my D10 Site...
have it in my composer Json.. using Drupal Lenient Composer Endpointso i was just thinking about other users...
or you as a maintainer to just have to merge the request... - First commit to issue fork.