Paragraphs form alter requires paragraph types to be set, but perhaps shouldn't?

Seems the 'Create merge request' button is broken at the moment. If you press 'Compare' on the MR, its ready to go.

Hi @scott_euser,
yes what you're saying makes a lot of sense.
I'm uploading a patch that should do the work.

Hope it helps,
aronne.

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

Hi aronne → ,

It looks like this was reverted by this commit on 8.x-1.6 )(and 8.x-1.x) fixing Issue #3395691 → ?

Omg yes, thank you @andreastkdf
I'm gonna upload the new patch now.

Thanks again.
aronne

Thanks!

Hello. I recently update this module to latest 1.7.0 version and I noticed this patch.
It is not implemented correctly and might lead to issues.
In my case I am using pluginformalter_form_alter_info_alter so I can dynamically add all taxonomy term form ids. This way if I create new taxonomy, the plugin for form alter will automatically work for it and I limit the risk to forget to include its specific form id.
Here it comes the issue: For you the change is working because you expect that $this->getDefinitions() doesn't return you a result and the validation below doesn't matter. You can not hit it.
In my case $this->getDefinitions() and the following $definitions = $this->findDefinitions() uses my form alter and return a results. This lead me to your change and !isset($definition['paragraph_type']) always return true and it tries to create new instance for something that is not correct.