Deprecate the services_tfa module

The 2.x change is RTBC, in my opinion :)

For 1.x, I'd prefer if the GenericValidation class would be annotated to indicate deprecation in addition to the lifecycle property in the .info.yml.. Not sure how well the static code analysers pick up the info.yml information, but I'm pretty sure they do pick up that type of information from code comments. I need to clean the spiderwebs out of my PhpStorm install, but until I do, this is one way of doing the annotation: https://www.drupal.org/about/core/policies/core-change-policies/drupal-d... →

Static analysis probably won't pick-up the info.yml so fair point, adding the deprecated flag to the class itself will help make sure anyone who is extending it without having the module itself enabled will get notified of the deprecation.

I'll add the deprecation flag to the docblock later today.

Automatically closed - issue fixed for 2 weeks with no activity.