8.x-1.0 is not Drupal 8 compatible

Open on Drupal.org →

Created on 19 October 2023, 8 months ago

Problem/Motivation

Recent Drupal 10 fixes to the module have introduced changes that are no longer compatible with Drupal 8, despite claimed core_version_requirement: ^8 || ^9 || ^10

I know it's EOL already, but many sites still exist and they trying to be upgraded to Drupal 9 and 10. If there's no viable upgrade path any more, it makes the job immensely harder.

Steps to reproduce

Update module to 8.x-1.0 on a Drupal 8 site in prep for upgrade to Drupal 9.

Proposed resolution

Create new branch and release which is Drupal 9 and Drupal 10 compatible. This could easily be the existing release.
Back out the Drupal 10 compatibility fixes from 8.x-1.x and make a new release which is only Drupal 8 and Drupal 9 supporting.

Alternatively, just pull D8 support from existing branch. Not ideal but I'll have posted the branch here for people to use if needed.

Remaining tasks

Create a 2.0.x branch from existing HEAD
Make release 2.0.0 from 2.0.x branch using core_version_requirement: ^9.1 || ^10
Back out Drupal 10 compatability fixes from 8.x-1.x branch
Make a 8.x-1.2 release using core_version_requirement: ^8.8 || ^9

User interface changes

None.

API changes

Use Drupal 8+9 API only for 8.x-1.x branch.

Data model changes

None.

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇦🇺Australia ELC

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @ELC
Comment 8 months ago →
🇦🇺Australia ELC
Fix typo in issue summary.
@elc opened merge request.
Status changed to Needs review 8 months ago2:39am 19 October 2023
Comment 8 months ago →
🇦🇺Australia ELC
The core: 8.x must be removed from cas_server.info.yml for all versions. Minimum D8 version bumped to 8.8 (it's actually 8.7.7 but I rounded up). See change notice https://www.drupal.org/node/3070687 →

The 2.0.x branch needs to be made core_version_requirement: ^9.1 || ^10 only as the event dispatching is only compatible with 9.1 and above. See change notice https://www.drupal.org/node/3159012 →

The event dispatching in 8.x-1.x had to be reverted to old method compatible with D8 and D9 only as per the above change notice.

Need a 2.0.x branch to be created to allow the needed fixups for that version.

Comment 8 months ago →

ELC → committed 55558d9b on 8.x-1.x

Issue #3395056 by ELC: Revert 8.x-1.x branch to D8 compatible

Revert...

Status changed to Fixed 8 months ago3:58pm 19 October 2023
Comment 8 months ago →
🇦🇺Australia ELC
Hopefully that should be all right and ready for a tag.
Comment 8 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024