Contrib.social

SqlContentEntityStorageRevisionDataCleanupTest does not run

Open on Drupal.org →
Created on 15 October 2023, about 2 years ago
Updated 7 May 2024, over 1 year ago

Problem/Motivation

The test added in 🐛 Add upgrade path to clean up deleted revisions from node_field_revision Fixed doesn't run since it was placed in core/modules/system/src instead of core/modules/system/test/src.

Steps to reproduce

% ../vendor/bin/phpunit --list-tests | grep SqlContentEntityStorageRevisionDataCleanupTest

Result turns up empty. The test is not discovered by phpunit.

Proposed resolution

git mv core/modules/system/src/Tests/Entity/Update/SqlContentEntityStorageRevisionDataCleanupTest.php core/modules/system/tests/src/Functional/Update/SqlContentEntityStorageRevisionDataCleanupTest.php

And adapt the namespace accordingly.

Note to reviewers: Use the following command to verify whether phpunit discovers the test (inside the core subdirectory):

% ../vendor/bin/phpunit --list-tests | grep SqlContentEntityStorageRevisionDataCleanupTest
 - Drupal\Tests\system\Functional\Update\SqlContentEntityStorageRevisionDataCleanupTest::testRevisionDataCleanup

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Fixed

Version

10.2 ✨

Component
Entity  →

Last updated 21 days ago

Created by

🇨🇭Switzerland znerol

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024