Fix PHP Unit tests and code style

Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::testMasqueradeAsRole Undefined property: Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user /builds/wsg/drupal9/web/modules/contrib/masquerade_as_role/tests/src/Functional/MasqueradeAsRoleTest.php:29 /builds/wsg/drupal9/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 3) Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::testCleanupRegular Undefined property: Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user /builds/wsg/drupal9/web/modules/contrib/masquerade_as_role/tests/src/Functional/MasqueradeAsRoleTest.php:73 /builds/wsg/drupal9/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 4) Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::testMasqueradeAsRoleCron Undefined property: Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user /builds/wsg/drupal9/web/modules/contrib/masquerade_as_role/tests/src/Functional/MasqueradeAsRoleTest.php:95 /builds/wsg/drupal9/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

------ ------------------------------------------------------------------------------------------------------------------- Line modules/contrib/masquerade_as_role/tests/src/Functional/MasqueradeAsRoleTest.php ------ ------------------------------------------------------------------------------------------------------------------- 29 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 34 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$auth_user. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 39 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 41 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$editor_role. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 42 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$moderator_role. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 45 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 46 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 53 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 55 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 63 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 73 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 77 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$editor_role. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 78 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$moderator_role. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 95 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 99 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$editor_role. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 100 Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$moderator_role. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property ------ -------------------------------------------------------------------------------------------------------------------

---------------------------------------------------------------------- FILE: ...s/contrib/masquerade_as_role/src/Controller/SwitchController.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The | | first wrong one is | | Drupal\masquerade\Controller\SwitchController. ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...web/modules/contrib/masquerade_as_role/masquerade_as_role.module ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The | | first wrong one is | | Drupal\Core\Block\BlockPluginInterface. ----------------------------------------------------------------------

Comments & Activities

Issue created by @karolinam
Comment 9 months ago →
🇨🇦Canada karolinam
@karolinam opened merge request.
Issue was unassigned.
Status changed to Needs review 9 months ago7:28pm 13 October 2023
Comment 9 months ago →
🇨🇦Canada karolinam
Please see MR for code changes which fix the errors listed in the description.
First commit to issue fork.
Comment 8 months ago →
System Message

mvc → committed baddcff8 on 1.0.x authored by karolinam →
Issue #3394021: Fix PHP Unit tests and code style

Fix PHP Unit tests and code style

Problem/Motivation

Steps to reproduce

PHPUnit

PHPCS

Proposed resolution

Comments & Activities