Unit Test NodeCreationTest incompatible with simplenews 4.0.0-alpha3

Open on Drupal.org →

Created on 13 October 2023, 9 months ago

Problem/Motivation

The phpunit test SimplenewsSchedulerNodeCreationTest fails in combination with simplenews 4.0.0-alpha3 because the function outline of Drupal\simplenews\Subscription\SubscriptionManager::subscribe has changed.

Steps to reproduce

Get a Drupal 10 instance
Require drupal\simplenews:4.0.0-alpha3
Require drupal\simplenews_scheduler:4.0.0-alpha1
Run phpunit test SimplenewsSchedulerNodeCreationTest

Proposed resolution

Change call of \Drupal::service('simplenews.subscription_manager')->subscribe(...) to suit new function outline.
Rerun Test to verify.

🐛 Bug report

Status

Fixed

Version

4.0

Component

Code

Created by

🇩🇪Germany JoCowood Kamp-Lintfort

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @JoCowood
Status changed to Needs review 9 months ago9:02am 13 October 2023
Comment 9 months ago →
🇩🇪Germany JoCowood Kamp-Lintfort
I created a patch.
Status changed to RTBC 9 months ago9:16am 13 October 2023
Comment 9 months ago →
🇩🇪Germany Goldfit
I was able to reproduce the bug and tested out the provided patch. It solved the issue and can be implemented.

Comment 9 months ago →

5df19cb3 committed on 4.x

Issue #3393871 by JoCowood: Fix unit test subscribe function call

Status changed to Fixed 9 months ago9:18am 13 October 2023
Comment 9 months ago →
🇩🇪Germany JoCowood Kamp-Lintfort
Comment 8 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024