- Issue created by @mikegodin
- last update
about 1 year ago Composer require failure - @mikegodin opened merge request.
- πΊπΈUnited States mikegodin
The MR 191, when tested locally, passed all PHP Unit tests and all Upgrade Status tests with no deprecation warnings.
- last update
about 1 year ago 76 pass, 1 fail - last update
about 1 year ago Composer require failure - last update
about 1 year ago 119 pass - last update
about 1 year ago Composer require failure - last update
about 1 year ago 119 pass - πΊπΈUnited States mikegodin
Noting that the "PHP 7.4 & MySQL 5.7, D10.1.4 Composer require failure" is expected since Drupal 10 requires PHP 8.1.
- Status changed to Needs review
about 1 year ago 9:28am 13 October 2023 - last update
about 1 year ago 119 pass - πΊπΈUnited States mikegodin
If it is necessary to install this fork via composer before it gets merged, edit
composer.json
, replacing:"repositories": [ { "type": "composer", "url": "https://packages.drupal.org/8" }
with
"repositories": [ { "type": "composer", "url": "https://packages.drupal.org/8", "exclude": [ "drupal/openid_connect" ] }, { "type": "git", "url": "https://git.drupalcode.org/issue/openid_connect-3393666.git" }
Then require via composer:
composer require 'drupal/openid_connect:dev-3393666-drupal-10-compatibility' --with-all-dependencies
- First commit to issue fork.
- last update
about 1 year ago Composer require failure - π©πͺGermany Harlor Berlin
@mikegodin, THX for your help!
I asked one of the maintainers(sanduhrs) about this and w decided to bring back the deprecation annotations because these functions are not static in 2.x and 3.x.
I also moved the helper method from the tests to a trait so we don't need to duplicate it.
- last update
about 1 year ago 119 pass - Status changed to RTBC
about 1 year ago 2:36pm 17 October 2023 - π©πͺGermany Harlor Berlin
I manually tested these changes with a Drupal 10. And it seemed to work just fine!
Even though I made the last changes to the MR I set this to RTBC - my changes where purely cosmetic and coordinated with sanduhrs.
-
sanduhrs β
committed af328211 on 8.x-1.x authored by
mikegodin β
Issue #3393666: Drupal 10 compatibility for 8.x-1.x
-
sanduhrs β
committed af328211 on 8.x-1.x authored by
mikegodin β
- Status changed to Fixed
about 1 year ago 3:23pm 17 October 2023 - π©πͺGermany sanduhrs πͺπΊ Heidelberg, Germany, Europe
Merged, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.