- Issue created by @neclimdul
- π¦πΉAustria drunken monkey Vienna, Austria
Thanks for reporting this problem, and great job on the fix! The only problem here is that events were unfortunately introduced only pretty recently (in 4.2.3) in the Search API Solr module, so we cannot assume that everyone who is using this module also uses a version of Search API Solr that uses events. I think for the near term we should make sure to work both with hooks and events.
The attached patch revision should ensure this. Please give it a try! - πΊπΈUnited States neclimdul Houston, TX
Makes sense. I don't know where the patch I wrote ended up but it was pretty similar we just put the logic from the function in the event which let it be cleaned up a little bit.
- π¦πΉAustria drunken monkey Vienna, Austria
I hid your patch since I find it less confusing if only the latest version of a patch is visible in the issue description. Just click βShow 2 more filesβ to see it.
Anyways, did you test my patch and verify it also works for you? -
drunken monkey β
committed c985df72 on 1.x
Issue #3393447 by drunken monkey, neclimdul: Fixed compatibility with...
-
drunken monkey β
committed c985df72 on 1.x
- Status changed to Fixed
over 1 year ago 11:33am 22 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.