- Issue created by @douggreen
- Status changed to Needs review
over 1 year ago 5:42pm 11 October 2023 - Status changed to RTBC
over 1 year ago 10:02am 13 October 2023 - πΊπ¦Ukraine paulrad
Conforming the correctness of changes in @douggreen's patch according to the documentation β .
Moving to RTBC. -
douggreen β
authored 9f026ace on 8.x-1.x
Issue #3393385 by douggreen, paulrad: Libraries license definition is...
-
douggreen β
authored 9f026ace on 8.x-1.x
- π¬π§United Kingdom aaron.ferris
Confirmed patch applies cleanly and is correct, thanks both for this. Committed and pushed to 8.x.1.x
- Status changed to Fixed
over 1 year ago 11:08am 19 October 2023 - Status changed to RTBC
over 1 year ago 3:18pm 19 October 2023 - πΊπΈUnited States douggreen Winchester, VA
You committed something different than my patch, now we have duplicate dependencies in the definition.
- πΊπΈUnited States douggreen Winchester, VA
I'm attaching a new patch that reverts the previous commit and still makes my change from above.
-
douggreen β
authored ce213222 on 8.x-1.x
Issue #3393385 by douggreen, aaron.ferris, paulrad: Libraries license...
-
douggreen β
authored ce213222 on 8.x-1.x
- Status changed to Fixed
over 1 year ago 4:21pm 19 October 2023 - π¬π§United Kingdom aaron.ferris
Yes indeed, very odd - teaches me to rush. Thanks, this should now be resolved.
- πΊπΈUnited States douggreen Winchester, VA
lol, no worries, I made a similar mistake earlier today with another module! It happens.
- πΊπΈUnited States douggreen Winchester, VA
Can you cut a new release so that we can stop using the dev branch please :)
- π¬π§United Kingdom aaron.ferris
Sadly I can't, I don't have the rights to administer releases so this will be one for @monymirza
Automatically closed - issue fixed for 2 weeks with no activity.