- Issue created by @louis-cuny
- @louis-cuny opened merge request.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 1:39pm 11 October 2023 - 🇫🇷France louis-cuny
louis-cuny → changed the visibility of the branch 3393309-remove-legacy-configinstall to hidden.
- Status changed to RTBC
8 months ago 8:27am 9 April 2024 - 🇫🇷France louis-cuny
I don't understand why the MR is blank
but https://git.drupalcode.org/issue/kafka-3393309/-/compare/8.x-1.x...8.x-1.x - 🇫🇷France fgm Paris, France
LGTM. I double checked and could not find any remaining config reference, even like
Drupal::config
.However, the module currently requires core 8|9|10 but won't install on 10 because of the psr/log 1 requirement, which should be adjusted to 1|3 to support D10. Also, it would be good if the composer.json would allow ext-rdkafka 6 too, as that is the current version on PECL, but that's for another issue.
- 🇬🇧United Kingdom astoker88
https://www.drupal.org/project/kafka/issues/3318381 📌 Bump ext-rdkafka dependency for PHP 8.1 and D10 compatibility Needs work
The PSR log dependency was fixed via this MR some time ago - https://www.drupal.org/project/kafka/issues/3318381 📌 Bump ext-rdkafka dependency for PHP 8.1 and D10 compatibility Needs work
Currently running on multiple 10.1.x instances with this patch applied.
If anything needs a re-roll/ new MR let me know , happy to contribute time to getting the module updated.
- 🇫🇷France fgm Paris, France
That new MR still references psr/log:^1.0 ? https://git.drupalcode.org/issue/kafka-3393309/-/blob/8.x-1.x/composer.json
The PSR log dependency seems not to have been completed: the issue is still CNW.
- 🇫🇷France louis-cuny
The MR on this issue is about removing the install/config file
About psr/log dependency, the MR is this one: https://git.drupalcode.org/project/kafka/-/merge_requests/2
From issue https://www.drupal.org/project/kafka/issues/3318381 📌 Bump ext-rdkafka dependency for PHP 8.1 and D10 compatibility Needs work