third party settings not removed from EntityViewDisplay when the module is uninstalled

Created on 11 October 2023, over 1 year ago

Problem/Motivation

After uninstalling the module, if we export the configuration for our project via drush or via single export we still see traces of the third_party settings set by the module at the entity_view_display configs. They should be cleaned when we uninstall the module via hook_uninstall(). As an example, if we had a content type "Article" if we export the config "core.entity_view_display.node.article.default"
we still see third_party_settings related to panelizer after un-installing the module:

....
third_party_settings:
  panelizer:
    enable: false
    custom: false
    allow: false
    default: default
....

Steps to reproduce

Install the module as usual
Make usage of the module as usual.
Export the configuration via drush cex or other method.
Uninstall the module
Export again the configuration via drush cex or other method.
As a result, the third_party_settings used by the module is still present on the configuration and it is not cleaned.

Proposed resolution

We should implements hook_uninstall() to clean this config.

🐛 Bug report

Status

Needs review

Version

5.0

Component

Code

Created by

🇪🇸Spain jlbellido

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @jlbellido
Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
last update over 1 year ago
Waiting for branch to pass
@jlbellido opened merge request.
Status changed to Needs review over 1 year ago1:38pm 11 October 2023
Comment over 1 year ago →
🇪🇸Spain jlbellido
I've provided a MR with a first attempt to fix the issue which worked for me.
Cheers

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024