- Issue created by @elc
- last update
about 1 year ago 21 pass, 2 fail - @elc opened merge request.
- last update
about 1 year ago 23 pass - Status changed to Needs review
about 1 year ago 1:40am 11 October 2023 - 🇦🇺Australia elc
Tests needed to have a mocked Batch API style call for them to complete.
As a note for anyone still updating a site from D8, using version 2.1.0 of the Fraction module (last version marked compatible) and the fraction.post_update.php from this merge to get the schema update completed if it times out. It is effectively the same file and source schema from back then.
- Status changed to Closed: won't fix
about 1 year ago 9:22pm 23 October 2023 - 🇺🇸United States m.stenta
Thanks for contributing this @ELC!!
However, because this is a significant change, and it changes an update hook (which only affects a very limited set of users), and the original issue is "fixed" for (hopefully) most users, and the number of users on 8.x-1.x is limited and dropping (according to usage statistics → ), and I do not have the time to review and test it thoroughly myself, from a maintainer's perspective I'm inclined to just leave this MR as an option for others who need it, but close this issue as "won't fix".
That said, if someone else runs into the same problem (hopefully not!), and they dig in and discover this issue, and they contribute some time to review and test it (to get another perspective and context as a form of due-diligence), then we can reopen and merge it. Does that seem fair?
Credit where credit is due! Simply opening this issue and contributing the MR is a huge contribution! Thank you again!