Fix the issues reported by phpcs

Created on 10 October 2023, over 1 year ago

Updated 12 October 2023, over 1 year ago

Problem/Motivation

FILE: C:\Mywork\htdocs\d9test\web\themes\contrib\harmony_haven\config\install\block.block.harmony_haven_account_menu.yml
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
27 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: C:\Mywork\htdocs\d9test\web\themes\contrib\harmony_haven\config\install\block.block.harmony_haven_powered.yml
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
22 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------

FILE: C:\Mywork\htdocs\d9test\web\themes\contrib\harmony_haven\css\font-awesome.css
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------

FILE: C:\Mywork\htdocs\d9test\web\themes\contrib\harmony_haven\css\styles.css
--------------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 11 LINES
--------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
1 | ERROR | [x] Selectors must be on a single line
167 | ERROR | [x] Whitespace found at end of line
385 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
480 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
882 | ERROR | [x] Whitespace found at end of line
884 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
885 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1
886 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
887 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
888 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
889 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------

FILE: C:\Mywork\htdocs\d9test\web\themes\contrib\harmony_haven\harmony_haven.info.yml
-------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------
20 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------

FILE: C:\Mywork\htdocs\d9test\web\themes\contrib\harmony_haven\harmony_haven.libraries.yml
------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------
17 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------

FILE: C:\Mywork\htdocs\d9test\web\themes\contrib\harmony_haven\harmony_haven.theme
--------------------------------------------------------------------------------------------------------------------------------
FOUND 38 ERRORS AND 1 WARNING AFFECTING 34 LINES
--------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
9 | WARNING | [x] Unused use statement
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
17 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
18 | ERROR | [x] Closing brace indented incorrectly; expected 0 spaces, found 1
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
30 | ERROR | [x] Whitespace found at end of line
32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
33 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
34 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
35 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6
36 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6
37 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
40 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
41 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
43 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
54 | ERROR | [x] No space found before comment text; expected "// copy right variables." but found "//copy right variables."
54 | ERROR | [x] Inline comments must start with a capital letter
58 | ERROR | [x] No space found before comment text; expected "// left header variables" but found "//left header variables"
58 | ERROR | [x] Inline comments must start with a capital letter
58 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
63 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 39 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------

FILE: C:\Mywork\htdocs\d9test\web\themes\contrib\harmony_haven\js\bootstrap.min.js
----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------------------

FILE: C:\Mywork\htdocs\d9test\web\themes\contrib\harmony_haven\js\jquery-3.1.1.min.js
-------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-------------------------------------------------------------------------------------

FILE: C:\Mywork\htdocs\d9test\web\themes\contrib\harmony_haven\theme-settings.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 59 ERRORS AND 7 WARNINGS AFFECTING 48 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
9 | WARNING | [x] Unused use statement
13 | ERROR | [x] Doc comment short description must start with a capital letter
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
29 | ERROR | [x] Array indentation error, expected 5 spaces but found 4
30 | ERROR | [x] Array indentation error, expected 5 spaces but found 4
31 | ERROR | [x] Array indentation error, expected 5 spaces but found 4
32 | ERROR | [x] Array indentation error, expected 5 spaces but found 4
33 | ERROR | [x] Array closing indentation error, expected 3 spaces but found 2
55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 5
56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 5
57 | ERROR | [x] Array indentation error, expected 7 spaces but found 6
58 | ERROR | [x] Array indentation error, expected 7 spaces but found 6
59 | ERROR | [x] Array indentation error, expected 7 spaces but found 6
60 | ERROR | [x] Array indentation error, expected 7 spaces but found 6
61 | ERROR | [x] Array closing indentation error, expected 5 spaces but found 4
62 | ERROR | [x] Whitespace found at end of line
63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
69 | ERROR | [x] Whitespace found at end of line
70 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
76 | ERROR | [x] No space found before comment text; expected "// >>>>>>>>>>>>>Left Header>>>>>>>>>>>>" but found "//>>>>>>>>>>>>>Left Header>>>>>>>>>>>>"
99 | WARNING | [x] There must be no blank line following an inline comment
99 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
100 | ERROR | [x] Whitespace found at end of line
101 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
101 | ERROR | [x] Short array syntax must be used to define arrays
102 | ERROR | [x] Array indentation error, expected 2 spaces but found 4
103 | ERROR | [x] Array indentation error, expected 2 spaces but found 4
104 | ERROR | [x] Array indentation error, expected 2 spaces but found 4
105 | ERROR | [x] Array indentation error, expected 2 spaces but found 4
106 | ERROR | [x] Array closing indentation error, expected 0 spaces but found 2
107 | ERROR | [x] Short array syntax must be used to define arrays
113 | ERROR | [x] Short array syntax must be used to define arrays
127 | ERROR | [x] Short array syntax must be used to define arrays
129 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
129 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
129 | ERROR | [x] Concat operator must be surrounded by a single space
133 | ERROR | [x] Short array syntax must be used to define arrays
135 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
135 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
135 | ERROR | [x] Concat operator must be surrounded by a single space
135 | ERROR | [x] Concat operator must be surrounded by a single space
138 | ERROR | [x] Short array syntax must be used to define arrays
140 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
140 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
140 | ERROR | [x] Concat operator must be surrounded by a single space
140 | ERROR | [x] Concat operator must be surrounded by a single space
145 | ERROR | [x] Short array syntax must be used to define arrays
147 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
147 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
147 | ERROR | [x] Concat operator must be surrounded by a single space
147 | ERROR | [x] Concat operator must be surrounded by a single space
150 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
150 | ERROR | [x] Short array syntax must be used to define arrays
151 | ERROR | [x] Array indentation error, expected 8 spaces but found 6
152 | ERROR | [x] Array indentation error, expected 8 spaces but found 6
152 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
152 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
152 | ERROR | [x] Concat operator must be surrounded by a single space
152 | ERROR | [x] Concat operator must be surrounded by a single space
153 | ERROR | [x] Array indentation error, expected 8 spaces but found 6
154 | ERROR | [x] Array closing indentation error, expected 6 spaces but found 4
156 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 3 empty lines
158 | ERROR | [ ] More than 2 empty lines are not allowed
159 | ERROR | [x] Expected 1 newline at end of file; 2 found
---------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 55 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

Install Harmony Haven theme and perform PHPCS for Drupal Standards

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig,js

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Closed: duplicate

Version

1.0

Component

Code

Created by

🇮🇳India Gautam_105@

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @Gautam_105@
Assigned to Shreya_98
Comment over 1 year ago →
🇮🇳India Shreya_98
First commit to issue fork.
@souvik_banerjee opened merge request.
Status changed to Needs review over 1 year ago6:09am 10 October 2023
Comment over 1 year ago →
🇮🇳India souvik_banerjee
Hi! I have solved the errors given by phpcs, please review
Status changed to Closed: duplicate over 1 year ago10:06am 12 October 2023
Comment over 1 year ago →
🇮🇳India soumya soni indore
I won't be fixing this issue as this issue is already been submitted.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024