- Issue created by @fjgarlin
- Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - @fjgarlin opened merge request.
- last update
about 1 year ago 30,384 pass - Status changed to Needs review
about 1 year ago 5:51pm 9 October 2023 - Status changed to RTBC
about 1 year ago 5:57pm 9 October 2023 - 🇬🇧United Kingdom catch
Looks good, will commit in the morning if nothing comes up.
- 🇳🇱Netherlands bbrala Netherlands
Yeah, this is good. Silly that slipped through.
- Status changed to Fixed
about 1 year ago 8:39am 10 October 2023 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!
- 🇬🇧United Kingdom catch
I think there's something still wrong here:
declare -x _TARGET_DB="mysql-8" declare -x _TARGET_DB_TYPE="mysql" declare -x _TARGET_DB_VERSION="5.7"
From https://git.drupalcode.org/project/drupal/-/jobs/165210
Note TARGET_DB there is mysql-8 so it doesn't match the test against _TARGET_DB when determining SIMPLETEST_DB
- Status changed to Active
about 1 year ago 9:31am 12 October 2023 - 🇬🇧United Kingdom catch
Re-opening, I think the database type checks are wrong now, or I'm missing something.
- 🇬🇧United Kingdom catch
Also the scheduled branch tests look wrong to me, only running on one environment.
https://git.drupalcode.org/project/drupal/-/pipelines?scope=branches&page=1
- First commit to issue fork.
- last update
about 1 year ago 30,394 pass - 🇬🇧United Kingdom longwave UK
Branch tests look OK to me: https://git.drupalcode.org/project/drupal/-/pipelines/29420 ran on four environments, failed on one.
- Status changed to Needs review
about 1 year ago 12:04pm 12 October 2023 - Status changed to RTBC
about 1 year ago 12:40pm 12 October 2023 - 🇪🇸Spain fjgarlin
Doh! I should have remembered that change too! Thanks for fixing that. Looks good.
- Status changed to Fixed
about 1 year ago 2:40pm 12 October 2023 - 🇬🇧United Kingdom longwave UK
Committed and pushed 8e33624c95 to 11.x and 64113ded7b to 10.2.x and 9538b30d4d to 10.1.x. Thanks!
-
longwave →
committed 9538b30d on 10.1.x
Issue #3392739 followup by fjgarlin, longwave, catch: _TARGET_DB_TYPE...
-
longwave →
committed 9538b30d on 10.1.x
-
longwave →
committed 64113ded on 10.2.x
Issue #3392739 followup by fjgarlin, longwave, catch: _TARGET_DB_TYPE...
-
longwave →
committed 64113ded on 10.2.x
-
longwave →
committed 8e33624c on 11.x
Issue #3392739 followup by fjgarlin, longwave, catch: _TARGET_DB_TYPE...
-
longwave →
committed 8e33624c on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.