In some search Taxonomy::getSiblingIds() results in endless loop
Difficult to say how to reproduce it as it relates to specific search results. It happens when $topLevelTerms is empty in the the first call of getSiblingIds() so it triggers second invoke: $this->getSiblingIds($ids, $parentIds). By the definition of function getSiblingIds(), this second call loops the original $ids again while using $parentIds as "$activeIds" which does not feel right. In addition to that, the condition check: if (!$activeIds || in_array($id, $activeIds)) would never be true in this case since $parentIds is not empty while $id is not in $activeIds($parentIds).
return array_diff(
array_merge(
$childIds,
$topLevelTerms,
(!$topLevelTerms && $parentSiblings) ? $this->getSiblingIds($ids, $parentIds) : []
),
$ids
);Feels to me the intention of (!$topLevelTerms && $parentSiblings) ? $this->getSiblingIds($ids, $parentIds) : [] is trying to fetch top level terms so it should be fixed as (!$topLevelTerms && $parentSiblings) ? $this->getSiblingIds($parentIds) : []
Needs work
3.0
Code
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
I'm not sure about that solution.
It would be great to have a test first that demonstrates the endless loop.