Contrib.social

Promotion applies() doesn't exclude $this when checking other promotions, if set as COMPATIBLE_NONE

Open on Drupal.org →
Created on 6 October 2023, about 2 years ago
Updated 29 November 2023, almost 2 years ago

Steps to reproduce:

  • create a promotion, set it as not compatible with any other promotions, and create a coupon for it
  • create a draft order, apply the coupon, save
  • reopen the order edit page and attempt to save

Result: saving fails with error message on the coupon field: "The provided coupon code code is invalid".

Proposed resolution:

Method \Drupal\commerce_promotion\Entity\Promotion::applies() needs to exclude $this promotion when checking against the already saved promotions from the $order.

🐛 Bug report
Status

Fixed

Version

2.36

Component

Promotions

Created by

ts.ag

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024