- Issue created by @T.Barker
- 🇦🇺Australia T.Barker
Attaching the patch I have written to address this issue.
- First commit to issue fork.
- last update
about 1 year ago 34 pass - @abhishek_virasat opened merge request.
- Status changed to Needs review
about 1 year ago 6:05am 6 October 2023 - last update
about 1 year ago 34 pass - 🇮🇳India abhishek_virasat
@Luke.Leber, added new condition for fix this issue "PHP error on embedding Youtube Shorts". please kindly review the MR
- 🇺🇸United States luke.leber Pennsylvania
Hello @abhishek_virasat,
There was already a patch added in #2. Your merge request does not add any additional value and will not be considered for contribution credit. Please collaborate with community peers versus starting new work.
- 🇺🇸United States luke.leber Pennsylvania
Thanks for the bug report, Tom. I'll take some time this morning to update the tests and add additional coverage with this.
- last update
about 1 year ago 20 pass, 1 fail - 🇺🇸United States luke.leber Pennsylvania
These new test cases should prove that there's a bug to fix here.
The last submitted patch, 8: 3392082-8-test-only.patch, failed testing. View results →
- last update
about 1 year ago 46 pass - 🇺🇸United States luke.leber Pennsylvania
...and this should prove that it's fixed!
I slightly extended #2 in order to also support playlists...not sure how I missed that originally. I'm going to move onto manual testing if the test bot is green with this one :-).
- 🇺🇸United States luke.leber Pennsylvania
Manual testing all passed on www.worldcampus.psu.edu on Friday, so I will be merging and cutting a new patch release Monday morning, following internal peer review, unless otherwise noted.
Cheers
-
Luke.Leber →
authored ea37579c on 2.0.x
Issue #3392082 by Luke.Leber, T.Barker: PHP error on embedding Youtube...
-
Luke.Leber →
authored ea37579c on 2.0.x
- 🇺🇸United States luke.leber Pennsylvania
Committed and pushed to 2.0.x, thanks Tom!
I'll cut 2.0.4 stable this week to ship the fixes.
- Status changed to Fixed
about 1 year ago 3:13pm 9 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
3 months ago 1:39am 13 September 2024