Parser error after update to 2.1.0 or 1.1.0

This doesn't demonstrate the bug. I had a hard time writing a test for it. I can't set the missing config setting to NULL in the test due to schema validation. Let me know if this isn't a sufficient fix. The patch just updates the site configuration to add the missing setting. Admittedly, I didn't think this was necessary and it would be ok for the setting to be NULL.

I thought you should be able to delete a config, which results in it being null?

The update script should probably only set the config if it's unset / null?

For some reason, I thought that I couldn't test this because I couldn't make the setting NULL. But for whatever reason it's allowing me to do that tonight.

I plan on adding the update function back in, but I want to demonstrate the bug and the fix first.

The update script should probably only set the config if it's unset / null?

Yes, you're right. Once again, I shouldn't write code past midnight, let alone at 1:15AM. Hopefully I would have caught it later during my own review.

The last submitted patch, 5: 3391504-5-test-only.patch, failed testing. View results →

And here's one with the update function added in.

Thank you for looking over the patch, @mfb.

Automatically closed - issue fixed for 2 weeks with no activity.