- Issue created by @makbeta
- last update
about 1 year ago 130 pass - @makbeta opened merge request.
- Status changed to Needs review
about 1 year ago 6:00am 4 October 2023 - last update
about 1 year ago Patch Failed to Apply - 🇮🇳India abhishek_virasat
@makbeta, I have fixed the issue on my local. please review the patch file
- last update
about 1 year ago 130 pass - 🇮🇳India abhishek_virasat
@makbeta, I have fixed the issue on my local. there is some issue. so please review the patch file "conditional_fields-3391444-1.patch"
- 🇺🇸United States makbeta
@abhishek_virasat, I didn't attach a patch, but contributed my code directly in Gitlab and submitted a merge request, so it's easier for the module maintainers to incorporate the solution. The merge request can be viewed as a patch by adding
.diff
to the end, if it's ever needed to be incorporated into a composer file.Ex: https://git.drupalcode.org/project/conditional_fields/-/merge_requests/3...
Both our solutions are valid, and pass the automated test.
I went with the more concise syntax with indirect conditional, I would say it would be up to the module maintainers to decide which approach they would want to incorporate.