WindowsAadSSORouteSubscriber is never called due to doc comment errors

Created on 3 October 2023, about 1 year ago

Problem/Motivation

openid_connect_windows_aad/src/Controller/WindowsAadSSOController.php:logout() is never called, because the doc comment in openid_connect_windows_aad/src/Routing/WindowsAadSSORouteSubscriber.php is incorrectly written.

Currently it says:

/**
 * Listens to the dynamic route events.
 */
class WindowsAadSSORouteSubscriber extends RouteSubscriberBase {

... while it needs to say the following in order to be picked up by Symfony:

/**
 * Class WindowsAadSSORouteSubscriber.
 *
 * @package Drupal\openid_connect_windows_aad\Routing
 */
class WindowsAadSSORouteSubscriber extends RouteSubscriberBase {

Steps to reproduce

Set a breakpoint at line 18 of src/Routing/WindowsAadSSORouteSubscriber.php:

if ($route = $collection->get('user.logout')) {

... noting that the line is never called.

Proposed resolution

Patch attached which also fixes the incorrect use of an unknown Exception.

🐛 Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom alexharries

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024