Contrib.social

Require 100%, not 90% of modules to be Drupal 10-installable before failing the "šŸ›°ļø Drupal 10-installability: vetted" CI job

Open on Drupal.org ā†’
Created on 30 September 2023, about 1 year ago
Updated 2 October 2023, about 1 year ago

Problem/Motivation

The first nightly test run for the recommendations after publicly releasing AM:A failed the Drupal 10-installability job.

That job tries to install all the vetted recommendations on Drupal 10. It passes tests as long as the % that is installable, is low enough, the script does this:

echo "\nšŸŸ¢ Drupal 10 compatibility coverage on (vetted recommendations): " . round($compatibility_coverage, 2) . "%";
echo "\nšŸŸ¢ Drupal 10 compatibility module count on (vetted recommendations): " . $compatible_module_count . "/" . $total_module_count;
if ($compatibility_coverage > 90) {
  exit(1);
}

It looks like literally in the 12 hours since making the announcement, one more module was made Drupal 10-compatible šŸ˜…

It reached 90.96%, versus <90% 24 hours earlier!

Steps to reproduce

Proposed resolution

At least one more very important module is missing: https://www.drupal.org/project/bean_migrate ā†’ . Possibly several. So I think it's time to reassess this "90% threshold".

A more pragmatic approach might be to require 100% but allow this CI job to fail. That way, until it's green, switching to Drupal 10 (a huge effort!!) would result in net fewer sites being able to migrate to "modern Drupal".

Remaining tasks

User interface changes

API changes

Data model changes

šŸ“Œ Task
Status

Fixed

Version

1.8

Component

Recommendations

Created by

šŸ‡§šŸ‡ŖBelgium wim leers Ghent šŸ‡§šŸ‡ŖšŸ‡ŖšŸ‡ŗ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024