Sorting By Incorrect Column On Duplicate Column Names

Created on 28 September 2023, 9 months ago

Problem/Motivation

When creating a view with one or more table relationships, it's possible that you have duplicate column names.
i.e. table1 > name
table2 > name

When you try to make both fields sortable, clicking on Name (table 2) column, actually sorts the table by Name (table 1).

The problem appears to be in:
/modules/contrib/views_aggregator/src/Plugin/views/style/Table::compareResultRows line 1410.

Steps to reproduce

1. Create a new view that against a table.
2. Add a relationship to a 2nd table that has a duplicate column name. i.e Table 1 > UserID, Table 2 > UserID.
3. Make both columns sortable in the Table Aggregator Settings.
4. View the report and sort on each of the columns.
5. They'll both sort based on the first column, never the 2nd.

Proposed resolution

I created a workaround by replacing on line 1410: $field_handler->options['entity_field'] with $this->active.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States mitchmccoy

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @mitchmccoy
Comment 9 months ago →
🇺🇸United States mitchmccoy
Assigned to JordiK
Comment 9 months ago →
🇺🇸United States TR Cascadia
That piece of code was changed in #3059245: Rewrite main module functions to work with raw values → by @JordiK, so I'm assigning the issue to him to look at because I don't know exactly what the intent was in that change.

I don't think your workaround is the correct way to fix it though, because if the entity_id array element is not being accessed then we don't need to check to see if it's set anymore. But why was it being used in the first place? @JordiK should know ...

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024