- Issue created by @adamzimmermann
- @adamzimmermann opened merge request.
- πΊπΈUnited States apotek
Here are usages of getContentItem() in the module:
grep -Rn getContentItem orange_dam orange_dam/src/OrangeDamApi.php:235: public function getContentItem(string $system_identifier) { orange_dam/src/OrangeDamQueueDataManager.php:195: if ($item = $this->orangeDamApi->getContentItem($system_identifier)) { orange_dam/src/OrangeDamQueueDataManager.php:406: $item = $this->orangeDamApi->getContentItem($system_id); orange_dam/src/Commands/OrangeDamCommands.php:737: if (!$item = $this->orangeDamApi->getContentItem($system_identifier)) {
Based on this, do we want to rename getContentItem() to queueContentItem() or keep it as is and create a new function called retrieveContentItem() :p that we call from within getContentItem()?
- Assigned to apotek
- Status changed to Needs review
9 months ago 12:46am 28 September 2023 - πΊπΈUnited States adamzimmermann
I went with this approach:
or keep it as is and create a new function called retrieveContentItem() :p that we call from within getContentItem()?
I named it slightly different though.
- Status changed to RTBC
9 months ago 8:40pm 28 September 2023 - πΊπΈUnited States apotek
I have tested this change in my latest development work and getting good results.
-
adamzimmermann β
committed 95a5c81e on 1.x
Issue #3390295 by adamzimmermann, apotek: Allow Search API to be called...
-
adamzimmermann β
committed 95a5c81e on 1.x
- Status changed to Fixed
9 months ago 12:04am 29 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.