Allow Search API to be called without Queuing an item

Created on 28 September 2023, 9 months ago
Updated 29 September 2023, 9 months ago

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States adamzimmermann

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @adamzimmermann
  • @adamzimmermann opened merge request.
  • πŸ‡ΊπŸ‡ΈUnited States apotek

    Here are usages of getContentItem() in the module:

    grep -Rn getContentItem orange_dam 
    orange_dam/src/OrangeDamApi.php:235:  public function getContentItem(string $system_identifier) {
    orange_dam/src/OrangeDamQueueDataManager.php:195:    if ($item = $this->orangeDamApi->getContentItem($system_identifier)) {
    orange_dam/src/OrangeDamQueueDataManager.php:406:      $item = $this->orangeDamApi->getContentItem($system_id);
    orange_dam/src/Commands/OrangeDamCommands.php:737:    if (!$item = $this->orangeDamApi->getContentItem($system_identifier)) {
    

    Based on this, do we want to rename getContentItem() to queueContentItem() or keep it as is and create a new function called retrieveContentItem() :p that we call from within getContentItem()?

  • Assigned to apotek
  • Status changed to Needs review 9 months ago
  • πŸ‡ΊπŸ‡ΈUnited States adamzimmermann

    I went with this approach:

    or keep it as is and create a new function called retrieveContentItem() :p that we call from within getContentItem()?

    I named it slightly different though.

  • Status changed to RTBC 9 months ago
  • πŸ‡ΊπŸ‡ΈUnited States apotek

    I have tested this change in my latest development work and getting good results.

  • Status changed to Fixed 9 months ago
  • πŸ‡ΊπŸ‡ΈUnited States adamzimmermann
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024