Use 'needs' instead of 'dependencies' to speed up gitlab CI jobs and run phpstan first

Quick win. Changes look good. RTBC.

+1 for needs.

P.S.: I wish GitLab's docs at https://docs.gitlab.com/ee/ci/yaml/ were clearer on when to use needs vs dependencies.

Sorry one more tweak - if we move phpstan higher up in the YAML, it'll get queued first as soon as composer finishes, giving it more of a chance of finishing when the other jobs do.

Reviewed and still looks good imo. It only changes the order of the phpcs vs phpstan, but the jobs are exactly the same.
Note that the UI sorts alphabetically (emoji and then name), so the change is only visible in code. ie: https://git.drupalcode.org/project/drupal/-/pipelines/24180

RTBC.

It looks like the pipeline is failing for this both before and after the rebase. Am I missing something?

lauriii → closed merge request !4889

@catch pointed out on Slack that the CI is failing due to something that shouldn't be impacted by the changes here:

ERROR: Job failed: prepare environment: waiting for pod running: pulling image "drupalci/php-8.2-apache:production": image pull failed: rpc error: code = Unknown desc = Error response from daemon: Head "https://registry-1.docker.io/v2/drupalci/php-8.2-apache/manifests/production": received unexpected HTTP status: 503 Service Unavailable. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information

Committed 6950ec5 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.