Gitlab testing has detected the following:
FILE: ...web/modules/custom/search_api_coveo/src/SearchApiCoveoClient.php
----------------------------------------------------------------------
FOUND 3 ERRORS AND 4 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------
331 | WARNING | [ ] Line exceeds 80 characters; contains 85
| | characters (Drupal.Files.LineLength.TooLong)
334 | WARNING | [ ] Line exceeds 80 characters; contains 132
| | characters (Drupal.Files.LineLength.TooLong)
357 | WARNING | [ ] Line exceeds 80 characters; contains 109
| | characters (Drupal.Files.LineLength.TooLong)
360 | WARNING | [ ] Line exceeds 80 characters; contains 122
| | characters (Drupal.Files.LineLength.TooLong)
371 | ERROR | [ ] The array declaration extends to column 111 (the
| | limit is 80). The array content should be split
| | up over multiple lines
| | (Drupal.Arrays.Array.LongLineDeclaration)
388 | ERROR | [x] Inline comments must start with a capital
| | letter
| | (Drupal.Commenting.InlineComment.NotCapital)
481 | ERROR | [ ] The array declaration extends to column 208 (the
| | limit is 80). The array content should be split
| | up over multiple lines
| | (Drupal.Arrays.Array.LongLineDeclaration)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...pi_coveo/web/modules/custom/search_api_coveo/src/LoggerTrait.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The
| | first wrong one is
| | Drupal\Core\Logger\RfcLogLevel.
| | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...o/web/modules/custom/search_api_coveo/src/CredentialProvider.php
----------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 6 LINES
----------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
| | (Drupal.Classes.UnusedUseStatement.UnusedUse)
8 | ERROR | [x] Use statements should be sorted alphabetically.
| | The first wrong one is
| | Drupal\Core\State\StateInterface.
| | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
92 | ERROR | [x] There must be exactly one blank line before the
| | tags in a doc comment
| | (Drupal.Commenting.DocComment.SpacingBeforeTags)
92 | ERROR | [ ] Missing parameter comment
| | (Drupal.Commenting.FunctionComment.MissingParamComment)
94 | ERROR | [ ] Description for the @return value is missing
| | (Drupal.Commenting.FunctionComment.MissingReturnComment)
103 | ERROR | [ ] Missing parameter comment
| | (Drupal.Commenting.FunctionComment.MissingParamComment)
105 | ERROR | [ ] Description for the @return value is missing
| | (Drupal.Commenting.FunctionComment.MissingReturnComment)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...pi_coveo/src/Plugin/search_api/backend/SearchApiCoveoBackend.php
----------------------------------------------------------------------
FOUND 9 ERRORS AND 6 WARNINGS AFFECTING 13 LINES
----------------------------------------------------------------------
12 | ERROR | [x] Use statements should be sorted alphabetically.
| | The first wrong one is
| | Drupal\Core\Form\FormStateInterface.
| | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
174 | WARNING | [ ] Line exceeds 80 characters; contains 89
| | characters (Drupal.Files.LineLength.TooLong)
227 | ERROR | [x] Missing function doc comment
| | (Drupal.Commenting.FunctionComment.Missing)
244 | ERROR | [x] Expected 1 space after "=>"; 2 found
| | (Squiz.WhiteSpace.OperatorSpacing.SpacingAfter)
247 | ERROR | [x] Expected 1 blank line after function; 2
| | found
| | (Squiz.WhiteSpace.FunctionSpacing.After)
351 | ERROR | [ ] Public method name
| | "SearchApiCoveoBackend::getOrganizationID" is
| | not in lowerCamel format
| | (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps)
361 | ERROR | [ ] Public method name
| | "SearchApiCoveoBackend::getSourceID" is not in
| | lowerCamel format
| | (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps)
435 | WARNING | [x] 'todo: the prefix of the fields needs to be
| | specified in a config file.' should match the
| | format '@todo Fix problem X here.'
| | (Drupal.Commenting.TodoComment.TodoFormat)
443 | WARNING | [ ] Line exceeds 80 characters; contains 107
| | characters (Drupal.Files.LineLength.TooLong)
443 | ERROR | [x] Inline comments must start with a capital
| | letter
| | (Drupal.Commenting.InlineComment.NotCapital)
444 | WARNING | [x] 'todo: create helper to check if is
| | system/internal coveo field.' should match the
| | format '@todo Fix problem X here.'
| | (Drupal.Commenting.TodoComment.TodoFormat)
471 | ERROR | [x] Inline comments must start with a capital
| | letter
| | (Drupal.Commenting.InlineComment.NotCapital)
493 | WARNING | [ ] Line exceeds 80 characters; contains 89
| | characters (Drupal.Files.LineLength.TooLong)
493 | ERROR | [x] Inline comments must start with a capital
| | letter
| | (Drupal.Commenting.InlineComment.NotCapital)
907 | WARNING | [ ] Line exceeds 80 characters; contains 91
| | characters (Drupal.Files.LineLength.TooLong)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...oveo/web/modules/custom/search_api_coveo/search_api_coveo.module
----------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 11 LINES
----------------------------------------------------------------------
53 | ERROR | [x] Inline comments must start with a capital
| | letter
| | (Drupal.Commenting.InlineComment.NotCapital)
60 | ERROR | [x] Inline comments must start with a capital
| | letter
| | (Drupal.Commenting.InlineComment.NotCapital)
91 | WARNING | [ ] Only string literals should be passed to t()
| | where possible
| | (Drupal.Semantics.FunctionT.NotLiteralString)
95 | ERROR | [x] Inline comments must start with a capital
| | letter
| | (Drupal.Commenting.InlineComment.NotCapital)
105 | ERROR | [x] Inline comments must start with a capital
| | letter
| | (Drupal.Commenting.InlineComment.NotCapital)
123 | ERROR | [x] Inline comments must start with a capital
| | letter
| | (Drupal.Commenting.InlineComment.NotCapital)
134 | ERROR | [x] Inline comments must start with a capital
| | letter
| | (Drupal.Commenting.InlineComment.NotCapital)
166 | ERROR | [ ] All functions defined in a module file must be
| | prefixed with the module's name, found
| | "_create_link" but expected
| | "search_api_coveo__create_link"
| | (Drupal.NamingConventions.ValidFunctionName.InvalidPrefix)
188 | ERROR | [ ] All functions defined in a module file must be
| | prefixed with the module's name, found
| | "_create_configuration_url" but expected
| | "search_api_coveo__create_configuration_url"
| | (Drupal.NamingConventions.ValidFunctionName.InvalidPrefix)
202 | ERROR | [ ] All functions defined in a module file must be
| | prefixed with the module's name, found
| | "check_coveo_server_id" but expected
| | "search_api_coveo_check_coveo_server_id"
| | (Drupal.NamingConventions.ValidFunctionName.InvalidPrefix)
228 | ERROR | [ ] All functions defined in a module file must be
| | prefixed with the module's name, found
| | "display_message" but expected
| | "search_api_coveo_display_message"
| | (Drupal.NamingConventions.ValidFunctionName.InvalidPrefix)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 294ms; Memory: 8MB
PHP CODE SNIFFER REPORT SUMMARY
----------------------------------------------------------------------
FILE ERRORS WARNINGS
----------------------------------------------------------------------
...s/custom/search_api_coveo/search_api_coveo.module 10 1
...ustom/search_api_coveo/src/CredentialProvider.php 6 1
...dules/custom/search_api_coveo/src/LoggerTrait.php 1 0
...tom/search_api_coveo/src/SearchApiCoveoClient.php 3 4
...ugin/search_api/backend/SearchApiCoveoBackend.php 9 6
----------------------------------------------------------------------
A TOTAL OF 29 ERRORS AND 12 WARNINGS WERE FOUND IN 13 FILES
----------------------------------------------------------------------
PHPCBF CAN FIX 20 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
----------------------------------------------------------------------
SOURCE COUNT
----------------------------------------------------------------------
[x] Drupal.Commenting.InlineComment.NotCapital 10
[ ] Drupal.Files.LineLength.TooLong 8
[ ] Drupal.NamingConventions.ValidFunctionName.InvalidPrefix 4
[x] SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses. 3
[ ] Drupal.Arrays.Array.LongLineDeclaration 2
[ ] Drupal.Commenting.FunctionComment.MissingParamComment 2
[ ] Drupal.Commenting.FunctionComment.MissingReturnComment 2
[x] Drupal.Commenting.TodoComment.TodoFormat 2
[ ] Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCap 2
[x] Drupal.Classes.UnusedUseStatement.UnusedUse 1
[x] Drupal.Commenting.DocComment.SpacingBeforeTags 1
[x] Drupal.Commenting.FunctionComment.Missing 1
[ ] Drupal.Semantics.FunctionT.NotLiteralString 1
[x] Squiz.WhiteSpace.FunctionSpacing.After 1
[x] Squiz.WhiteSpace.OperatorSpacing.SpacingAfter 1
----------------------------------------------------------------------
A TOTAL OF 41 SNIFF VIOLATIONS WERE FOUND IN 15 SOURCES
----------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SOURCES AUTOMATICALLY (20 VIOLATIONS IN TOTAL)
----------------------------------------------------------------------
/builds/project/search_api_coveo/web/modules/custom/search_api_coveo/search_api_coveo.info.yml
7:1 error Expected indentation of 2 spaces but found 1 spaces yml/indent
✖ 1 problem (1 error, 0 warnings)
Fixed
1.0
Code
Issue #3389894 by FatherShawn: Coding Standards
Automatically closed - issue fixed for 2 weeks with no activity.