- Issue created by @pfrenssen
- πΊπΈUnited States MegaKeegMan
Making an attempt at this. Will push shortly.
- @megakeegman opened merge request.
- Status changed to Needs review
about 1 year ago 4:27pm 28 September 2023 - πΊπΈUnited States MegaKeegMan
This does not have to be the approach taken, but I do like that all of these extra dependencies no longer need to be installed. Another consideration here is the compatibility with different versions of drupal/core-recommended.
Drupal 9 core-recommended's symfony/yaml is constrained to "~v4.4.45"
Drupal 10's is "~v6.3.0"the 4.x branch (master) of qr-code-bundle: "^5.4||^6.0" constraint on symfony/yaml
the 3.x branch of qr-code-bundle: "^3.4||^4.4||^5.0"So if we want to keep the qr-code-bundle library, then I think we need to drop d8 and d9 compatibility on our 4.0.x branch
and drop d10 compatibility on our 3.0.x branchThat is of course assuming a core-recommended installation, and I am not 100% sure that core-recommended gets to be the determiner here.
-
MegaKeegMan β
committed 93e52cd2 on 4.0.x
Issue #3389713: Consider replacing qr-code-bundle dependency with the...
-
MegaKeegMan β
committed 93e52cd2 on 4.0.x
- Status changed to RTBC
about 1 year ago 11:53am 25 October 2023 - π§π¬Bulgaria pfrenssen Sofia
This looks great to me, thanks for addressing it!
- Status changed to Fixed
about 1 year ago 7:29pm 25 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.