- Issue created by @chambers
- 🇺🇸United States chambers
I just realized both of these places has a version check and if it is an older drupal version to use the deprecated method. Its throwing an error but there should be no issues for Drupal 10.
- Assigned to abhishek_virasat
- last update
over 1 year ago 227 pass - @abhishek_virasat opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:24am 26 September 2023 - 🇮🇳India abhishek_virasat
@chambers, I fixed this issue and created MR kindly review the changes
- Status changed to Active
over 1 year ago 10:39am 28 September 2023 - 🇬🇧United Kingdom jonathan1055
@abhishek_virasat Maybe you did not read comment #3 before you created the MR and you did not understand what was reported in this issue. There is no problem with trying to use
getImplementations()because this is only done when the core version is earlier than 9.4. So there is nothing that needs changing here.@chambers I presume the warnings you posted in the issue summary were from a code scan like PHPstan or something similar? It would be useful if PHPstan had a way to make a code line as "OK this is not an error" so that we do not keep getting these warning. PHPCS has this functionality and it very useful.
@steinmb Scheduler still maintains support for sites back to Core 8.8.3 currently, to help them during upgrade to 9.x and 10.x See the system requirement in scheduler.info.yml When that becomes too difficult or tedious or time-comsuming then Scheduler 2.0 will drop early core version support.