Old content with different line endings can break diff entirely

Comments & Activities

Issue created by @acbramley
Comment 9 months ago →
🇦🇺Australia mstrelan
This is introduced since DiffEngine is deprecated and replaced with sebastianbergmann/diff. Specifically the issue is that \Drupal\Component\Diff\DiffOpOutputBuilder::hunkOp does not handle \SebastianBergmann\Diff\Differ::DIFF_LINE_END_WARNING.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update 9 months ago
41 pass
@mstrelan opened merge request.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update 9 months ago
41 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update 9 months ago
30 pass, 4 fail
Status changed to Postponed 9 months ago5:50am 26 September 2023
Comment 9 months ago →
🇦🇺Australia mstrelan
Opened 🐛 DiffOpOutputBuilder::hunkOp does not handle Differ::DIFF_LINE_END_WARNING Active . Postponing on that issue in case there's further work to be done here.
Comment 8 months ago →
🇺🇸United States micahw156
Confirming the patch for #3389715 resolved my use case for diff module errors.

Comments & Activities