- Issue created by @tdnshah
- @tdnshah opened merge request.
- 🇮🇳India sandipta
Can we use a different pattern here to avoid dependency on upstream dependencies. Please check out https://www.hashbangcode.com/article/drupal-9-extending-drupal-base-clas....
- 🇮🇳India tdnshah
Reviewed this and the implementation is not working and needs some more understanding on to to implement this hence rerolling the last update to version 1.
@sandipta I would be fine test locally if the implementation is working before update the patch or asking for review, as the implementation is also not considering all the steps mentioned the attached article link, also try to create a new issue fork and raise the PR so that anyone using the working patch via git link do not get impacted.Thanks
- Status changed to Closed: duplicate
about 1 year ago 5:35am 13 October 2023 - 🇦🇺Australia silverham
Closing this issue in favour of the orginal issue 🐛 SvgImageUrlFormatter parent construct wrong order Needs review where the newly attached patch fixes both issues buy using the suggestion (thanks!) to not override
__construct()
method but also reuse the parentcreate()
method, then assign property after object creation so it will be compatible with future releases.