Convert the Sector Distribution to a general project

Created on 21 September 2023, 9 months ago
Updated 29 November 2023, 7 months ago

We'd like to shift from github completely to drupalcode with the Drupal 10 compatible version of our distribution.

Distribution: https://drupal.org/project/sector

Composer namespace on the default branch has been updated to drupal/sector: https://git.drupalcode.org/project/sector/-/blob/10.0.x/composer.json?re...

Is this something that could be actioned so that we can use our distribution directly from Drupal.org and the Drupal namespace on Packagist.org?

πŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡³πŸ‡ΏNew Zealand dieuwe Auckland, NZ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue created by @dieuwe
  • πŸ‡³πŸ‡ΏNew Zealand dieuwe Auckland, NZ
  • Assigned to drumm
  • πŸ‡ΊπŸ‡ΈUnited States drumm NY, US
  • Status changed to Fixed 9 months ago
  • πŸ‡ΊπŸ‡ΈUnited States drumm NY, US

    Done and https://packagist.org/packages/drupal/sector will be available soon.

  • πŸ‡³πŸ‡ΏNew Zealand dieuwe Auckland, NZ

    One more question that I can't find an easy answer to: how do we set up packagist auto-update on general projects?

  • Status changed to Needs work 9 months ago
  • πŸ‡³πŸ‡ΏNew Zealand dieuwe Auckland, NZ

    Ah, I've just checked one of my other general projects and it auto-updates. So must be an issue with a converted project that requires more action?

  • πŸ‡ΊπŸ‡ΈUnited States drumm NY, US

    Packagist.org has been flagging errors it sees in the project’s repository:

     The drupal/sector package of which you are a maintainer has
    failed to update due to invalid data contained in your composer.json.
    Please address this as soon as possible since the package stopped updating.
    
    It is recommended that you use `composer validate` to check for errors when you
    change your composer.json.
    
    Below is the update log which should highlight errors as
    "Skipped branch ...":
    
    [Composer\Repository\InvalidRepositoryException]: Some branches contained invalid data and were discarded, it is advised to review the log and fix any issues present in branches
    
    Skipped tag 8.x-2.0-alpha1, invalid tag name
    Skipped tag 8.x-2.0-alpha2, invalid tag name
    Skipped tag 8.x-2.0-alpha3, invalid tag name
    Skipped tag 8.x-2.0-alpha4, invalid tag name
    Skipped tag 8.x-2.0-alpha5, invalid tag name
    Skipped tag 8.x-2.0-alpha6, invalid tag name
    Skipped tag 8.x-2.0-alpha7, invalid tag name
    Skipped tag 8.x-2.0-beta1, invalid tag name
    Skipped tag 8.x-2.0-beta2, invalid tag name
    Skipped tag 8.x-2.0-beta3, invalid tag name
    Skipped tag 8.x-2.0-beta4, invalid tag name
    Skipped tag 8.x-2.0-beta5, invalid tag name
    Skipped tag 8.x-3.0-beta1, invalid tag name
    Skipped tag 8.x-4.0-rc1, invalid tag name
    Skipped tag 8.x-4.0-rc2, invalid tag name
    Skipped tag 8.x-4.0-rc3, invalid tag name
    Skipped tag 8.x-4.0-rc4, invalid tag name
    Skipped branch 7.x-1.x, no composer file
    Skipped branch 8.x-1.x, Invalid package information: 
    require-dev.mikey179/vfsStream is invalid, it should not contain uppercase characters. Please use mikey179/vfsstream instead.

    I believe only the last error may be relevant. Even though it is an old branch, Packagist is emailing the Drupal Association engineering team as owner of the drupal/ Packagist namespace.

    We do push updates to Packagist.org shortly after commit, so changes should be appearing on Packagist.org within a few minutes.

  • πŸ‡³πŸ‡ΏNew Zealand dieuwe Auckland, NZ

    Thanks for that, and I have fixed the error in that old branch.

    Packagist still reports: "This package is not auto-updated" and we have to do it manually every time we tag a new release.

  • πŸ‡ΊπŸ‡ΈUnited States drumm NY, US

    Drupal.org pushes the update automatically within a few minutes of commit. Packagist.org does not know this, so it will have that message that can be safely ignored. You do not need to do anything manually.

  • πŸ‡³πŸ‡ΏNew Zealand dieuwe Auckland, NZ

    Yes, this works fine for all other project, but the drupal/sector package is still broken.

    Here is an example (assuming no one hit auto-update before you see it):

    Latest tag on Packagist is "10.0.0-alpha3" (https://packagist.org/packages/drupal/sector)

    Latest tag on Drupalcode is "10.0.0-alpha4" (https://git.drupalcode.org/project/sector/-/tags), pushed 4 days ago.

    Packagist will pick it up if someone manually pushes "Update Now".

  • πŸ‡ΊπŸ‡ΈUnited States drumm NY, US

    Drupal.org checks for conflicts before automatically pushing to Packagist.org. https://git.drupalcode.org/project/sector_theme introduced a new conflict 2 months ago when sector.info.yml was added.

    With Drupal's history of requiring components, requiring something like sector within the sector_theme project, we do provide metadata at https://packages.drupal.org/files/packages/8/p2/drupal/sector.json for the theme.

    Components of projects should get namespaced to avoid this happening, which we do for regular projects. This needs to be extended to general projects, and this metadata cleaned up.

  • Status changed to Fixed 7 months ago
  • πŸ‡³πŸ‡ΏNew Zealand dieuwe Auckland, NZ

    Thanks for the investigation on this drumm, very much appreciated.

    A good lesson on the importance of namespacing for the team here :)

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024