Node access control handler only respects 'administer nodes' on revision operatons

// Revision operations. if ($revision_permission_operation) { .... elseif ($account->hasPermission('administer nodes')) { return AccessResult::allowed()->cachePerPermissions(); }

if ($operation == 'delete' && $entity->isNew()) { return AccessResult::forbidden()->addCacheableDependency($entity); } if ($admin_permission = $this->entityType->getAdminPermission()) { return AccessResult::allowedIfHasPermission($account, $admin_permission); }

Comments & Activities

Issue created by @mglaman

Comment over 1 year ago →

🇺🇸United States mglaman WI, USA

The same is true for \Drupal\node\NodeAccessControlHandler::checkCreateAccess

Parent:

  protected function checkCreateAccess(AccountInterface $account, array $context, $entity_bundle = NULL) {
    if ($admin_permission = $this->entityType->getAdminPermission()) {
      return AccessResult::allowedIfHasPermission($account, $admin_permission);
    }
    else {
      // No opinion.
      return AccessResult::neutral();
    }
  }

Node:

  protected function checkCreateAccess(AccountInterface $account, array $context, $entity_bundle = NULL) {
    return AccessResult::allowedIf($account->hasPermission('create ' . $entity_bundle . ' content'))->cachePerPermissions();
  }

It should call the parent as well.

Status changed to Postponed: needs info about 1 month ago2:12am 25 March 2025
Comment about 1 month ago →
🇦🇺Australia acbramley
I don't think we could do this in a way that would preserve BC.

Instead we can improve the description of the administer nodes permission in 🐛 Improve 'administer content' permission description Needs work

I agree it's really not ideal, if we were to add an admin_permission I think it'd need to be a new permission.

Node access control handler only respects 'administer nodes' on revision operatons

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities