Don't assume 'field_branch_hours' is populated

Created on 20 September 2023, about 1 year ago

Problem/Motivation

I'm seeing a fatal caused by calling \Drupal\y_branch\BranchHoursHelper::getBranchHours() on a node without field_branch_hours set. It looks like the field is optional, so I reckon this should be supported. (Alternatively I guess the field could be made mandatory and we could throw if it's empty?)

Steps to reproduce

Pass a node without the field set to the method.

Proposed resolution

Don't just check if the field exists, check it's populated.

Remaining tasks

Thanks!

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom AndyF

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @AndyF
@andyf opened merge request.
Issue was unassigned.
Status changed to Needs review about 1 year ago2:22pm 20 September 2023
Comment about 1 year ago →
🇬🇧United Kingdom AndyF
Status changed to Fixed about 1 year ago3:08pm 20 September 2023
Comment about 1 year ago →
🇺🇦Ukraine podarok Ukraine
tnx
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024