Dependency to the old ckeditor breaks upgrade from D9 to D10

Created on 19 September 2023, about 1 year ago
Updated 20 September 2023, about 1 year ago

Problem/Motivation

When upgrading from D9 to D10 and executing a config import with drush, the following error is returned:
In ExtensionList.php line 522: The module ckeditor does not exist..

Proposed resolution

Update the dependency to ckeditor5 in linkit.info.yml, after doing so I'm able to peform a drush cim.

πŸ› Bug report
Status

Closed: won't fix

Version

6.1

Component

Code

Created by

πŸ‡³πŸ‡±Netherlands bojan_dev

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @bojan_dev
  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22
    last update about 1 year ago
    83 pass
  • @bojan_dev opened merge request.
  • Status changed to Needs review about 1 year ago
  • πŸ‡³πŸ‡±Netherlands bojan_dev
  • πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson

    Thanks! After thinking about this, I don't think there should be a dependency on CKEditor at all, either ckeditor or ckeditor5. This module provides a plugins for CKEditor 4 and CKEditor 5, but it also provides a field widget for the core Link field. So, in theory, someone could want to use this module only in that context, without CKEditor. This scenario may be more common in the future when ✨ Drastically improve the linking experience in CKEditor 5 Needs work lands in core.

  • πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson

    Actually, now that I look at the linkit.info.yml file rather than the diff, I see that the dependency on drupal:ckeditor is in test_dependencies. This makes more sense, since our team uses this module heavily with codebases that do not have ckeditor (4) present.

    It is therefore my hypothesis that the error In ExtensionList.php line 522: The module ckeditor does not exist.. may not in fact be coming from Linkit's declaration of drupal:ckeditor in test_dependencies.

    Therefore, I'd like to have further confirmation -- a demonstration of steps to reproduce with a generic Drupal 9 to 10 update -- before proceeding with removing a test dependency. Specifically, provide steps to reproduce that shows that a removal of ckeditor from core.extension in the site configuration and a programmatic uninstall of ckeditor prior to the drush cim still results in the error, and that the removal of the test_dependency resolves it, rather than a repeated drush cim.

    Thanks, bojan!

  • Status changed to Closed: won't fix about 1 year ago
  • πŸ‡³πŸ‡±Netherlands bojan_dev

    After some retesting, I figured out it had todo with core.extensions in my DB, had to write a hook_update to disable ckeditor before running drush cim. My bad, I will close the issue.

Production build 0.71.5 2024