- Issue created by @bojan_dev
- last update
about 1 year ago 83 pass - @bojan_dev opened merge request.
- Status changed to Needs review
about 1 year ago 8:50am 19 September 2023 - πΊπΈUnited States mark_fullmer Tucson
Thanks! After thinking about this, I don't think there should be a dependency on CKEditor at all, either
ckeditor
orckeditor5
. This module provides a plugins for CKEditor 4 and CKEditor 5, but it also provides a field widget for the core Link field. So, in theory, someone could want to use this module only in that context, without CKEditor. This scenario may be more common in the future when β¨ Drastically improve the linking experience in CKEditor 5 Needs work lands in core. - πΊπΈUnited States mark_fullmer Tucson
Actually, now that I look at the
linkit.info.yml
file rather than the diff, I see that the dependency ondrupal:ckeditor
is in test_dependencies. This makes more sense, since our team uses this module heavily with codebases that do not haveckeditor
(4) present.It is therefore my hypothesis that the error
In ExtensionList.php line 522: The module ckeditor does not exist..
may not in fact be coming from Linkit's declaration ofdrupal:ckeditor
in test_dependencies.Therefore, I'd like to have further confirmation -- a demonstration of steps to reproduce with a generic Drupal 9 to 10 update -- before proceeding with removing a test dependency. Specifically, provide steps to reproduce that shows that a removal of
ckeditor
fromcore.extension
in the site configuration and a programmatic uninstall ofckeditor
prior to thedrush cim
still results in the error, and that the removal of the test_dependency resolves it, rather than a repeateddrush cim
.Thanks, bojan!
- Status changed to Closed: won't fix
about 1 year ago 7:29am 20 September 2023 - π³π±Netherlands bojan_dev
After some retesting, I figured out it had todo with core.extensions in my DB, had to write a hook_update to disable ckeditor before running drush cim. My bad, I will close the issue.