Contrib.social

Show review button not working on form edit sign elements

Open on Drupal.org →
Created on 17 September 2023, over 1 year ago
Updated 18 September 2023, over 1 year ago

Problem/Motivation

The "Show remove button" configuration option doesn't appear to be working on Drupal 9.5 so all image/sign fields on form edit pages display the "Remove" button regardless of the configuration value.

Steps to reproduce

Using FF 116+ or Chrome 117+ and Drupal 9.5+ add two image fields to a content type, set the form widgets to 'Sign' for both fields, set the first image field to "Show remove button", ensure the second field has the "Show remove button" disabled, and save the form settings. Next try to create a new instance of the content type and scroll down to your two image/sign fields. Note that "Remove" button is showing for both fields even though it was only configured to show for one of them.

Proposed resolution

Fix the call to getSetting() and pass the value to boolval() to convert the value into a boolean TRUE/FALSE value.

Remaining tasks

Review and test the proposed patch

User interface changes

None

API changes

None

Data model changes

None

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States d.clarke

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024