Creation of dynamic property Drupal\lightning_scheduler\Time::$_serviceId is deprecated

First go at a patch to remove the workaround.

Hi @MrDaleSmith,
Please provides more steps for reproduce this issue

Those are the steps: use the module on PHP 8.2 and it generates a PHP notice.

Yes, simply running on PHP 8.2 triggers this warning. I have tested both versions and can verify it.

The provided patch also makes sense, given the 2 core issues have since been fixed. However, since this module is included with lightning_core, it's not possible to apply the patch as is using composer. This issues should be moved to the lightning core project and a patch for that setup accordingly.

Thank you @teknocat. I could not figure out for the life of me why lightning_scheduler 3.19 was being reported when we were installing dev-3297525-automated-drupal-10

Okay, since that class just helps mocking current time in tests, it is now moved to a test module without that dynamic property.

Automatically closed - issue fixed for 2 weeks with no activity.