- Issue created by @asrob
You are correctly setting it up. This looks like a bug in the code, changing the category and looking into it.
- Status changed to Needs work
about 1 year ago 8:22am 15 September 2023 To clarify. This is a bug, that existed for a long time, but we couldn't have implemented a fix, because filtering was not correctly implemented and reserved search_api_language value was not being indexed. With those fixes in place, with 2.x version this can be fixed.
So I've pushed a fix to the issue fork, that enables filtering based on language. @asrob you don't have to add langcode for indexing, since we already added search_api_language to the index, search API writes langcode there and is used by the search query to filter by language.
Have to write an automated test, just in case it breaks in future updates.
- 🇭🇺Hungary asrob Hungary 🇭🇺 🇪🇺
OK, great! I'd like to test it but I cannot see it in the issue fork yet.
Sorry Drupals gitlab has been slow for the last two weeks. Should be there now.
- @admirlju opened merge request.
- Status changed to Needs review
about 1 year ago 1:47pm 15 September 2023 - Status changed to RTBC
about 1 year ago 7:18pm 15 September 2023 - 🇭🇺Hungary asrob Hungary 🇭🇺 🇪🇺
I've tested it, using 2.x-dev and the plain diff above. It works well, thanks @admirlju!
- Status changed to Needs work
about 1 year ago 6:50am 21 September 2023 - 🇸🇮Slovenia bcizej
This works but we should use hidden and always enabled processor plugin https://www.drupal.org/docs/8/modules/search-api/getting-started/processors → .
Search method is already bloated with code and we will need to do some cleanup in the future but we can start here :)
- Status changed to Needs review
about 1 year ago 10:30am 25 September 2023 Move the language filtering to a hidden always active processor, making sure to only work with the meilisearch backend. I also moved the test to the correct directory.
- Status changed to RTBC
about 1 year ago 8:18am 27 September 2023 - 🇭🇺Hungary asrob Hungary 🇭🇺 🇪🇺
I've tested it again and works well. Thanks!
- Status changed to Needs review
about 1 year ago 9:14am 30 September 2023 - 🇸🇮Slovenia bcizej
I have removed the condition to skip filtering if "zxx" and "und" language are in filter. I also fixed the test as it was under incorrect namespace and was missing @group tag.
-
bcizej →
committed 87a68643 on 2.x authored by
admirlju →
Issue #3387304 by admirlju, bcizej, asrob: Filter search result by...
-
bcizej →
committed 87a68643 on 2.x authored by
admirlju →
- Status changed to Fixed
about 1 year ago 1:43pm 30 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.