Contrib.social

Remove wikimedia/composer-merge-plugin instructions and composer.libraries.json

Open on Drupal.org →
Created on 14 September 2023, over 1 year ago
Updated 29 February 2024, about 1 year ago

Problem/Motivation

This module requires usage of a specific library and provides instructions on how to use a composer plugin to merge composer data into the root composer.json.

The root composer.json is more privileged than package composer.json and can do things such as adding scripts. Additionally these custom repository definitions might pose a challenge for organizations that use custom centralized Packagist repositories where adding packages that are not automatically packaged need to be justified.

Steps to reproduce

Proposed resolution

Remove the instructions and the composer.libraries.json file and instead instruct users to add a composer/installers (which is a Drupal core requirement) entry to move enyo/dropzone into the libraries folder of the installation.

This will work since enyo/dropzone is already on Packagist and this is provided by the official Dropzone library organization with support from the maintainer, enyo.

This should be a backwards compatible change but allow existing users to remove the wikimedia plugin, and ensure new users don't need to install it.

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Closed: duplicate

Version

2.0

Component

Code

Created by

🇳🇱Netherlands kingdutch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @kingdutch
  • Status changed to Postponed over 1 year ago
  • Comment over 1 year ago →
    🇳🇱Netherlands kingdutch

    Marking this as postponed. From our point of evaluation it's still a good idea because we already had a plugin that worked. However I realised that it would require the https://github.com/oomphinc/composer-installers-extender/ plugin (which we were already using) but it seems that there's currently an issue specifically for projects of the library type: https://github.com/oomphinc/composer-installers-extender/issues/26

  • Status changed to Closed: duplicate about 1 year ago
  • Comment about 1 year ago →
    🇨🇭Switzerland berdir Switzerland

    I went down the same rabbit hole last night, but anyway, merge plugin or not has no impact on these problems. The only difference of using merge plugin or not is whether you copy & paste the repository definition into your root composer.json or merge it in automatically.

    I agree that merge plugin is no longer the recommended approach and I've removed the documentation about it, there is a single, updated composer way now in README since 📌 Installation not working with Dropzone 6 Needs review . But I did not remove the composer.libraries.json file because that would break existing installs using it and there's no need for that. Maybe in a 3.x if that ever happens.

    Closing as duplicate of the mentioned issue.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024