TypeError: Cannot access offset of type string on string in Drupal\eca_tamper\Plugin\ECA\Condition\Tamper->buildConfigurationForm()

The given MR will not solve the issue.

That error message sounds as if the classic modeller is providing a form element that's not an array, but a string.

So, in line 67 or the Tamper plugin, we should first verify if is_array($value).

@jurgenhaas, I have added the is_array($form[$key]) so that it checks whether the variable is array or not.

@keshavv, why it does not solves the error. Can you please explain it.

@jurgenhaas, I have added the is_array($form[$key]) so that it checks whether the variable is array or not.

Right, I missed that. But you can remove the isset($form[$key]) && check as that is always set within that foreach loop.

Hi @jurgenhaas, can you explain me why because I used so that it checks that it contains value or not.

Right, I missed that. But you can remove the isset($form[$key]) && check as that is always set within that foreach loop.

In this loop:

foreach ($form as $key => $value) {
  if (isset($form[$key])) {
    // THIS IS ALWAYS TRUE.
  }
}

the $form[$key] is always set, it doesn't need to be tested.

Hi @jurgenhaas, changed please verify.

Looks good to me. Now waiting for feedback from @keshavv

Hi @jurgenhaas, any updates.

@shubham_jain see my comment in #12: it looks good to me, now we need a review from @keshavv

@keshavv any chance for getting a review from you since you've set this to "Needs work" before we addressed that?

This is so disappointing when people are contributing or just leaving seemingly valuable comments, but then never get back to it, even when pinged or even approached directly. I have now merged this into 1.0.x and 2.0.x, not waiting for any of that never landing feedback.

Thanks @shubham_jain for your help on this.

Automatically closed - issue fixed for 2 weeks with no activity.

I had this exact problem, after updating to Drupal 10.2 and ECA 1.1.5 and ECA Tamper 1.0.5

After moving to ECA Tamper 1.0.x, with this commit, it worked again. Thanks all.