- Issue created by @ryanfc78
- πΊπΈUnited States ryanfc78
The comma is in the totals if it is a 5 digit number but if it becomes a 6 digit number the comma is removed. Trying to figure out why and how to change that.
- πΊπΈUnited States ryanfc78
Seems to leave the comma out anytime a multiple of 3 is entered. Tried with a 6 and 9 digit number and the , disappears in the number. If the number is a 4,5, 7 or 8 digit number the comma is in the correct place.
- πΊπΈUnited States chrisfromredfin Portland, Maine
I think I have most of the work done to fix this; I just still need to ship some of the block config settings down to the client to be accessible to JavaScript and I'll have it.
- πΊπΈUnited States chrisfromredfin Portland, Maine
Switching version to fix in latest first, then backport.
- Merge request !2switch JS to using Intl and allow settings locale and currency β (Open) created by chrisfromredfin
- πΊπΈUnited States chrisfromredfin Portland, Maine
Let me know if you're able to test this out. If it works for you I can do a new 8+ release then backport to 7.x
- Status changed to Needs review
8 months ago 4:11pm 27 March 2024 - π¬π§United Kingdom aaron.ferris
This MR is looking good to me off the latest version of the Module, Drupal 10.2.3
4 figures
Config:
Progress: 4000
Goal: 8000Actual:
Progress: 4,000
Goal: 8,0005 figures
Config:
Progress: 43000
Goal: 90000Actual:
Progress: 4,000
Goal: 8,0006 figures
Config:
Progress: 100000
Goal: 200000Actual:
Progress: 100,000
Goal: 200,0007 figures
Config:
Progress: 1200000
Goal: 2500000Actual:
Progress: 1,200,000
Goal: 2,500,000 - Status changed to RTBC
8 months ago 5:30pm 27 March 2024